[INFO] cloning repository https://github.com/apoelstra/rsgit
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/apoelstra/rsgit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapoelstra%2Frsgit", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapoelstra%2Frsgit'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 9a19f3342fc466622de5d052d418a93a1510bfab
[INFO] fixing apoelstra/rsgit against try#622891a4e29178280638a6b63a8908bde2c0c854+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817-2
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapoelstra%2Frsgit" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/apoelstra/rsgit
[INFO] finished tweaking git repo https://github.com/apoelstra/rsgit
[INFO] tweaked toml for git repo https://github.com/apoelstra/rsgit written to /workspace/builds/worker-3-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/apoelstra/rsgit on toolchain 622891a4e29178280638a6b63a8908bde2c0c854
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/apoelstra/rsgit already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition
[INFO] [stderr] (in the `git2` dependency)
[INFO] [stderr] warning: `git-utils` (manifest) generated 1 warning
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3a6becf2bc8dde7f3fa57ede90e4f284e72d296796fc446bbb1e2c7cc0530151" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 8deb27fe38a907cb42f8fb250e8aa37bc49c8cddec90ef49b6faf5b6eb3198f3
[INFO] running `Command { std: "docker" "start" "8deb27fe38a907cb42f8fb250e8aa37bc49c8cddec90ef49b6faf5b6eb3198f3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "8deb27fe38a907cb42f8fb250e8aa37bc49c8cddec90ef49b6faf5b6eb3198f3" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "8deb27fe38a907cb42f8fb250e8aa37bc49c8cddec90ef49b6faf5b6eb3198f3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "8deb27fe38a907cb42f8fb250e8aa37bc49c8cddec90ef49b6faf5b6eb3198f3" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }`
[INFO] [stderr] crater-edition-check: migrating to next edition
[INFO] [stderr]    Migrating Cargo.toml from 2018 edition to 2021
[INFO] [stderr] warning: Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition
[INFO] [stderr] (in the `git2` dependency)
[INFO] [stderr] warning: `git-utils` (manifest) generated 1 warning
[INFO] [stderr]    Compiling libc v0.2.132
[INFO] [stderr]    Compiling unicode-ident v1.0.3
[INFO] [stderr]    Compiling syn v1.0.99
[INFO] [stderr]    Compiling pkg-config v0.3.25
[INFO] [stderr]    Compiling crossbeam-epoch v0.9.10
[INFO] [stderr]     Checking tinyvec_macros v0.1.0
[INFO] [stderr]    Compiling rayon-core v1.9.3
[INFO] [stderr]    Compiling memchr v2.5.0
[INFO] [stderr]     Checking unicode-bidi v0.3.8
[INFO] [stderr]     Checking percent-encoding v2.2.0
[INFO] [stderr]    Compiling proc-macro2 v1.0.43
[INFO] [stderr]     Checking tinyvec v1.6.0
[INFO] [stderr]     Checking unicode-width v0.1.9
[INFO] [stderr]     Checking form_urlencoded v1.1.0
[INFO] [stderr]     Checking textwrap v0.11.0
[INFO] [stderr]     Checking crossbeam-channel v0.5.6
[INFO] [stderr]    Compiling rayon v1.5.3
[INFO] [stderr]     Checking crossbeam-deque v0.8.2
[INFO] [stderr]    Compiling quote v1.0.21
[INFO] [stderr]    Compiling anyhow v1.0.64
[INFO] [stderr]     Checking gimli v0.26.2
[INFO] [stderr]     Checking miniz_oxide v0.5.4
[INFO] [stderr]    Compiling jobserver v0.1.24
[INFO] [stderr]    Compiling proc-macro-error-attr v1.0.4
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]    Compiling cc v1.0.73
[INFO] [stderr]     Checking num_cpus v1.13.1
[INFO] [stderr]     Checking clap v2.34.0
[INFO] [stderr]     Checking unicode-normalization v0.1.21
[INFO] [stderr]     Checking object v0.29.0
[INFO] [stderr]     Checking log v0.4.17
[INFO] [stderr]     Checking remove_dir_all v0.5.3
[INFO] [stderr]     Checking fastrand v1.8.0
[INFO] [stderr]     Checking rustc-demangle v0.1.21
[INFO] [stderr]     Checking idna v0.3.0
[INFO] [stderr]     Checking either v1.8.0
[INFO] [stderr]     Checking tempfile v3.3.0
[INFO] [stderr]     Checking url v2.3.1
[INFO] [stderr]     Checking time v0.1.44
[INFO] [stderr]     Checking subprocess v0.2.9
[INFO] [stderr]    Compiling libz-sys v1.1.8
[INFO] [stderr]    Compiling libgit2-sys v0.12.26+1.3.0
[INFO] [stderr]    Compiling backtrace v0.3.66
[INFO] [stderr]    Compiling proc-macro-error v1.0.4
[INFO] [stderr]     Checking addr2line v0.17.0
[INFO] [stderr]    Compiling serde_derive v1.0.144
[INFO] [stderr]    Compiling structopt-derive v0.4.18
[INFO] [stderr]     Checking structopt v0.3.26
[INFO] [stderr]     Checking serde v1.0.144
[INFO] [stderr]     Checking toml v0.5.9
[INFO] [stderr]     Checking serde_json v1.0.85
[INFO] [stderr]     Checking git2 v0.13.25
[INFO] [stderr]     Checking git-utils v0.1.0 (/opt/rustwide/workdir)
[INFO] [stderr]    Migrating src/label-pr.rs from 2018 edition to 2021
[INFO] [stderr]    Migrating src/check-pr.rs from 2018 edition to 2021
[INFO] [stderr]        Fixed src/checks/rust.rs (1 fix)
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 47.86s
[INFO] [stderr] crater-edition-check: git-utils v0.1.0 (/opt/rustwide/workdir) updating edition from 2018 to 2021
[INFO] [stderr] warning: Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition
[INFO] [stderr] (in the `git2` dependency)
[INFO] [stderr] warning: `git-utils` (manifest) generated 1 warning
[INFO] [stderr]     Checking git-utils v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: field `0` is never read
[INFO] [stdout]   --> src/git.rs:25:24
[INFO] [stdout]    |
[INFO] [stdout] 25 | pub struct RepoRef<'a>(&'a ());
[INFO] [stdout]    |            -------     ^^^^^^
[INFO] [stdout]    |            |
[INFO] [stdout]    |            field in this struct
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider removing this field
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `number` is never read
[INFO] [stdout]   --> src/pr.rs:26:9
[INFO] [stdout]    |
[INFO] [stdout] 24 | pub struct PullRequest {
[INFO] [stdout]    |            ----------- field in this struct
[INFO] [stdout] 25 |     /// Number of the PR on Github/Gitlab
[INFO] [stdout] 26 |     pub number: usize,
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/git.rs:154:17
[INFO] [stdout]     |
[INFO] [stdout] 154 |     pub fn path(&self) -> Cow<str> {
[INFO] [stdout]     |                 ^^^^^     ^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                 |
[INFO] [stdout]     |                 the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 154 |     pub fn path(&self) -> Cow<'_, str> {
[INFO] [stdout]     |                               +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `0` is never read
[INFO] [stdout]   --> src/git.rs:25:24
[INFO] [stdout]    |
[INFO] [stdout] 25 | pub struct RepoRef<'a>(&'a ());
[INFO] [stdout]    |            -------     ^^^^^^
[INFO] [stdout]    |            |
[INFO] [stdout]    |            field in this struct
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider removing this field
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `number` is never read
[INFO] [stdout]   --> src/pr.rs:26:9
[INFO] [stdout]    |
[INFO] [stdout] 24 | pub struct PullRequest {
[INFO] [stdout]    |            ----------- field in this struct
[INFO] [stdout] 25 |     /// Number of the PR on Github/Gitlab
[INFO] [stdout] 26 |     pub number: usize,
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/git.rs:154:17
[INFO] [stdout]     |
[INFO] [stdout] 154 |     pub fn path(&self) -> Cow<str> {
[INFO] [stdout]     |                 ^^^^^     ^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                 |
[INFO] [stdout]     |                 the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 154 |     pub fn path(&self) -> Cow<'_, str> {
[INFO] [stdout]     |                               +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.74s
[INFO] [stderr] crater-edition-check: migrating to next edition
[INFO] [stderr]    Migrating Cargo.toml from 2018 edition to 2021
[INFO] [stderr] warning: Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition
[INFO] [stderr] (in the `git2` dependency)
[INFO] [stderr] warning: `git-utils` (manifest) generated 1 warning
[INFO] [stderr]     Checking git-utils v0.1.0 (/opt/rustwide/workdir)
[INFO] [stderr]    Migrating src/label-pr.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating src/check-pr.rs from 2021 edition to 2024
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> src/pr.rs:43:32
[INFO] [stdout]     |
[INFO] [stdout]  43 |         while let Some(tips) = stack.pop() {
[INFO] [stdout]     |                                ^^^^^^^^^^^
[INFO] [stdout]     |                                |
[INFO] [stdout]     |                                this value will be stored in a temporary; let us call it `#3`
[INFO] [stdout]     |                                up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout]  44 |             for tip in tips {
[INFO] [stdout]     |                 ---    ----
[INFO] [stdout]     |                 |      |
[INFO] [stdout]     |                 |      `iter` calls a custom destructor
[INFO] [stdout]     |                 |      `iter` will be dropped later as of Edition 2024
[INFO] [stdout]     |                 |      this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |                 |      `#1` will be dropped later as of Edition 2024
[INFO] [stdout]     |                 `tip` calls a custom destructor
[INFO] [stdout]     |                 `tip` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  51 |                 let mut parent_vec = Vec::with_capacity(tip.parent_count());
[INFO] [stdout]     |                     --------------
[INFO] [stdout]     |                     |
[INFO] [stdout]     |                     `parent_vec` calls a custom destructor
[INFO] [stdout]     |                     `parent_vec` will be dropped later as of Edition 2024
[INFO] [stdout]  52 |                 for parent in tip.parents() {
[INFO] [stdout]     |                     ------    -------------
[INFO] [stdout]     |                     |         |
[INFO] [stdout]     |                     |         this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                     |         `#2` will be dropped later as of Edition 2024
[INFO] [stdout]     |                     `parent` calls a custom destructor
[INFO] [stdout]     |                     `parent` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  61 |         }
[INFO] [stdout]     |         - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#3` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `iter` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `tip` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `parent_vec` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `parent` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]     = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]     --> src/cargo.rs:81:15
[INFO] [stdout]      |
[INFO] [stdout]   71 |         let mut popen = self
[INFO] [stdout]      |             ---------
[INFO] [stdout]      |             |
[INFO] [stdout]      |             `popen` calls a custom destructor
[INFO] [stdout]      |             `popen` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]   81 |         match bufread.lines().next() {
[INFO] [stdout]      |               ^^^^^^^^^^^^^^^
[INFO] [stdout]      |               |
[INFO] [stdout]      |               this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]      |               up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]   92 |     }
[INFO] [stdout]      |     - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]      |
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]     --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `popen` invokes this custom destructor
[INFO] [stdout]     --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/subprocess-0.2.9/src/popen.rs:1250:1
[INFO] [stdout]      |
[INFO] [stdout] 1250 | impl Drop for Popen {
[INFO] [stdout]      | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]      = warning: this changes meaning in Rust 2024
[INFO] [stdout]      = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]      = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]     --> src/cargo.rs:106:15
[INFO] [stdout]      |
[INFO] [stdout]  103 |         let mut popen = exec.popen().context("constructing rustc -V process")?;
[INFO] [stdout]      |             ---------
[INFO] [stdout]      |             |
[INFO] [stdout]      |             `popen` calls a custom destructor
[INFO] [stdout]      |             `popen` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  106 |         match bufread.lines().next() {
[INFO] [stdout]      |               ^^^^^^^^^^^^^^^
[INFO] [stdout]      |               |
[INFO] [stdout]      |               this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]      |               up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  117 |     }
[INFO] [stdout]      |     - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]      |
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]     --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `popen` invokes this custom destructor
[INFO] [stdout]     --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/subprocess-0.2.9/src/popen.rs:1250:1
[INFO] [stdout]      |
[INFO] [stdout] 1250 | impl Drop for Popen {
[INFO] [stdout]      | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]      = warning: this changes meaning in Rust 2024
[INFO] [stdout]      = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> src/pr.rs:43:32
[INFO] [stdout]     |
[INFO] [stdout]  43 |         while let Some(tips) = stack.pop() {
[INFO] [stdout]     |                                ^^^^^^^^^^^
[INFO] [stdout]     |                                |
[INFO] [stdout]     |                                this value will be stored in a temporary; let us call it `#3`
[INFO] [stdout]     |                                up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout]  44 |             for tip in tips {
[INFO] [stdout]     |                 ---    ----
[INFO] [stdout]     |                 |      |
[INFO] [stdout]     |                 |      `iter` calls a custom destructor
[INFO] [stdout]     |                 |      `iter` will be dropped later as of Edition 2024
[INFO] [stdout]     |                 |      this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |                 |      `#1` will be dropped later as of Edition 2024
[INFO] [stdout]     |                 `tip` calls a custom destructor
[INFO] [stdout]     |                 `tip` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  51 |                 let mut parent_vec = Vec::with_capacity(tip.parent_count());
[INFO] [stdout]     |                     --------------
[INFO] [stdout]     |                     |
[INFO] [stdout]     |                     `parent_vec` calls a custom destructor
[INFO] [stdout]     |                     `parent_vec` will be dropped later as of Edition 2024
[INFO] [stdout]  52 |                 for parent in tip.parents() {
[INFO] [stdout]     |                     ------    -------------
[INFO] [stdout]     |                     |         |
[INFO] [stdout]     |                     |         this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                     |         `#2` will be dropped later as of Edition 2024
[INFO] [stdout]     |                     `parent` calls a custom destructor
[INFO] [stdout]     |                     `parent` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  61 |         }
[INFO] [stdout]     |         - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#3` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `iter` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `tip` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `parent_vec` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `parent` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> src/check-pr.rs:266:15
[INFO] [stdout]     |
[INFO] [stdout] 233 |       let mut result = Ok(());
[INFO] [stdout]     |           ----------
[INFO] [stdout]     |           |
[INFO] [stdout]     |           `result` calls a custom destructor
[INFO] [stdout]     |           `result` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 264 |       for handle in exec_threads {
[INFO] [stdout]     |           ------    ------------
[INFO] [stdout]     |           |         |
[INFO] [stdout]     |           |         this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |           |         `#1` will be dropped later as of Edition 2024
[INFO] [stdout]     |           `handle` calls a custom destructor
[INFO] [stdout]     |           `handle` will be dropped later as of Edition 2024
[INFO] [stdout] 265 |           // FIXME should catch ctrl-C here signal everything to stop waiting
[INFO] [stdout] 266 |           match handle
[INFO] [stdout]     |  _______________^
[INFO] [stdout] 267 | |             .rx
[INFO] [stdout] 268 | |             .recv()
[INFO] [stdout] 269 | |             .expect("execution thread to not panic")
[INFO] [stdout] 270 | |             .with_context(|| format!("subthread: commit {}, check {}", handle.commit, handle.desc))
[INFO] [stdout]     | |                                                                                                   ^
[INFO] [stdout]     | |                                                                                                   |
[INFO] [stdout]     | |___________________________________________________________________________________________________this value will be stored in a temporary; let us call it `#4`
[INFO] [stdout]     |                                                                                                     up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 279 |                   let sig = git2::Signature::now("PR Checker", "prcheck@wpsoftware.net")
[INFO] [stdout]     |  _____________________---___-
[INFO] [stdout]     |  _____________________|_____|
[INFO] [stdout]     | |                     |
[INFO] [stdout]     | |                     `sig` calls a custom destructor
[INFO] [stdout]     | |                     `sig` will be dropped later as of Edition 2024
[INFO] [stdout] 280 | |                     .context("creating git signature for new note")?;
[INFO] [stdout]     | |                                                                    -
[INFO] [stdout]     | |____________________________________________________________________|
[INFO] [stdout]     | |____________________________________________________________________this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                                                                      `#2` will be dropped later as of Edition 2024
[INFO] [stdout] 281 |                   let note_oid = repo
[INFO] [stdout]     |  ________________________________-
[INFO] [stdout]     | |________________________________|
[INFO] [stdout] 282 | |                     .note(
[INFO] [stdout] 283 | |                         &sig,
[INFO] [stdout] 284 | |                         &sig,
[INFO] [stdout] ...   |
[INFO] [stdout] 290 | |                     .with_context(|| format!("Adding notes to {}", handle.commit))?;
[INFO] [stdout]     | |                                                                                   -
[INFO] [stdout]     | |___________________________________________________________________________________|
[INFO] [stdout]     | |___________________________________________________________________________________this value will be stored in a temporary; let us call it `#3`
[INFO] [stdout]     |                                                                                     `#3` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 298 | |     }
[INFO] [stdout]     | |     - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#4` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.64/src/error.rs:581:1
[INFO] [stdout]     |
[INFO] [stdout] 581 | impl Drop for Error {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `result` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.64/src/error.rs:581:1
[INFO] [stdout]     |
[INFO] [stdout] 581 | impl Drop for Error {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/mpmc/mod.rs:1411:0
[INFO] [stdout] note: `handle` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/mpmc/mod.rs:1411:0
[INFO] [stdout] note: `sig` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/signature.rs:142:1
[INFO] [stdout]     |
[INFO] [stdout] 142 | impl<'a> Drop for Signature<'a> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.64/src/error.rs:581:1
[INFO] [stdout]     |
[INFO] [stdout] 581 | impl Drop for Error {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/signature.rs:142:1
[INFO] [stdout]     |
[INFO] [stdout] 142 | impl<'a> Drop for Signature<'a> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#3` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.64/src/error.rs:581:1
[INFO] [stdout]     |
[INFO] [stdout] 581 | impl Drop for Error {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> src/pr.rs:43:32
[INFO] [stdout]     |
[INFO] [stdout]  43 |         while let Some(tips) = stack.pop() {
[INFO] [stdout]     |                                ^^^^^^^^^^^
[INFO] [stdout]     |                                |
[INFO] [stdout]     |                                this value will be stored in a temporary; let us call it `#3`
[INFO] [stdout]     |                                up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout]  44 |             for tip in tips {
[INFO] [stdout]     |                 ---    ----
[INFO] [stdout]     |                 |      |
[INFO] [stdout]     |                 |      `iter` calls a custom destructor
[INFO] [stdout]     |                 |      `iter` will be dropped later as of Edition 2024
[INFO] [stdout]     |                 |      this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |                 |      `#1` will be dropped later as of Edition 2024
[INFO] [stdout]     |                 `tip` calls a custom destructor
[INFO] [stdout]     |                 `tip` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  51 |                 let mut parent_vec = Vec::with_capacity(tip.parent_count());
[INFO] [stdout]     |                     --------------
[INFO] [stdout]     |                     |
[INFO] [stdout]     |                     `parent_vec` calls a custom destructor
[INFO] [stdout]     |                     `parent_vec` will be dropped later as of Edition 2024
[INFO] [stdout]  52 |                 for parent in tip.parents() {
[INFO] [stdout]     |                     ------    -------------
[INFO] [stdout]     |                     |         |
[INFO] [stdout]     |                     |         this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                     |         `#2` will be dropped later as of Edition 2024
[INFO] [stdout]     |                     `parent` calls a custom destructor
[INFO] [stdout]     |                     `parent` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  61 |         }
[INFO] [stdout]     |         - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#3` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `iter` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `tip` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `parent_vec` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `parent` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]     = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]     --> src/cargo.rs:81:15
[INFO] [stdout]      |
[INFO] [stdout]   71 |         let mut popen = self
[INFO] [stdout]      |             ---------
[INFO] [stdout]      |             |
[INFO] [stdout]      |             `popen` calls a custom destructor
[INFO] [stdout]      |             `popen` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]   81 |         match bufread.lines().next() {
[INFO] [stdout]      |               ^^^^^^^^^^^^^^^
[INFO] [stdout]      |               |
[INFO] [stdout]      |               this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]      |               up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]   92 |     }
[INFO] [stdout]      |     - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]      |
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]     --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `popen` invokes this custom destructor
[INFO] [stdout]     --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/subprocess-0.2.9/src/popen.rs:1250:1
[INFO] [stdout]      |
[INFO] [stdout] 1250 | impl Drop for Popen {
[INFO] [stdout]      | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]      = warning: this changes meaning in Rust 2024
[INFO] [stdout]      = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]      = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]     --> src/cargo.rs:106:15
[INFO] [stdout]      |
[INFO] [stdout]  103 |         let mut popen = exec.popen().context("constructing rustc -V process")?;
[INFO] [stdout]      |             ---------
[INFO] [stdout]      |             |
[INFO] [stdout]      |             `popen` calls a custom destructor
[INFO] [stdout]      |             `popen` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  106 |         match bufread.lines().next() {
[INFO] [stdout]      |               ^^^^^^^^^^^^^^^
[INFO] [stdout]      |               |
[INFO] [stdout]      |               this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]      |               up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  117 |     }
[INFO] [stdout]      |     - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]      |
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]     --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `popen` invokes this custom destructor
[INFO] [stdout]     --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/subprocess-0.2.9/src/popen.rs:1250:1
[INFO] [stdout]      |
[INFO] [stdout] 1250 | impl Drop for Popen {
[INFO] [stdout]      | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]      = warning: this changes meaning in Rust 2024
[INFO] [stdout]      = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> src/pr.rs:43:32
[INFO] [stdout]     |
[INFO] [stdout]  43 |         while let Some(tips) = stack.pop() {
[INFO] [stdout]     |                                ^^^^^^^^^^^
[INFO] [stdout]     |                                |
[INFO] [stdout]     |                                this value will be stored in a temporary; let us call it `#3`
[INFO] [stdout]     |                                up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout]  44 |             for tip in tips {
[INFO] [stdout]     |                 ---    ----
[INFO] [stdout]     |                 |      |
[INFO] [stdout]     |                 |      `iter` calls a custom destructor
[INFO] [stdout]     |                 |      `iter` will be dropped later as of Edition 2024
[INFO] [stdout]     |                 |      this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |                 |      `#1` will be dropped later as of Edition 2024
[INFO] [stdout]     |                 `tip` calls a custom destructor
[INFO] [stdout]     |                 `tip` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  51 |                 let mut parent_vec = Vec::with_capacity(tip.parent_count());
[INFO] [stdout]     |                     --------------
[INFO] [stdout]     |                     |
[INFO] [stdout]     |                     `parent_vec` calls a custom destructor
[INFO] [stdout]     |                     `parent_vec` will be dropped later as of Edition 2024
[INFO] [stdout]  52 |                 for parent in tip.parents() {
[INFO] [stdout]     |                     ------    -------------
[INFO] [stdout]     |                     |         |
[INFO] [stdout]     |                     |         this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                     |         `#2` will be dropped later as of Edition 2024
[INFO] [stdout]     |                     `parent` calls a custom destructor
[INFO] [stdout]     |                     `parent` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout]  61 |         }
[INFO] [stdout]     |         - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#3` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `iter` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `tip` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `parent_vec` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `parent` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/commit.rs:388:1
[INFO] [stdout]     |
[INFO] [stdout] 388 | impl<'repo> Drop for Commit<'repo> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> src/check-pr.rs:266:15
[INFO] [stdout]     |
[INFO] [stdout] 233 |       let mut result = Ok(());
[INFO] [stdout]     |           ----------
[INFO] [stdout]     |           |
[INFO] [stdout]     |           `result` calls a custom destructor
[INFO] [stdout]     |           `result` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 264 |       for handle in exec_threads {
[INFO] [stdout]     |           ------    ------------
[INFO] [stdout]     |           |         |
[INFO] [stdout]     |           |         this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |           |         `#1` will be dropped later as of Edition 2024
[INFO] [stdout]     |           `handle` calls a custom destructor
[INFO] [stdout]     |           `handle` will be dropped later as of Edition 2024
[INFO] [stdout] 265 |           // FIXME should catch ctrl-C here signal everything to stop waiting
[INFO] [stdout] 266 |           match handle
[INFO] [stdout]     |  _______________^
[INFO] [stdout] 267 | |             .rx
[INFO] [stdout] 268 | |             .recv()
[INFO] [stdout] 269 | |             .expect("execution thread to not panic")
[INFO] [stdout] 270 | |             .with_context(|| format!("subthread: commit {}, check {}", handle.commit, handle.desc))
[INFO] [stdout]     | |                                                                                                   ^
[INFO] [stdout]     | |                                                                                                   |
[INFO] [stdout]     | |___________________________________________________________________________________________________this value will be stored in a temporary; let us call it `#4`
[INFO] [stdout]     |                                                                                                     up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 279 |                   let sig = git2::Signature::now("PR Checker", "prcheck@wpsoftware.net")
[INFO] [stdout]     |  _____________________---___-
[INFO] [stdout]     |  _____________________|_____|
[INFO] [stdout]     | |                     |
[INFO] [stdout]     | |                     `sig` calls a custom destructor
[INFO] [stdout]     | |                     `sig` will be dropped later as of Edition 2024
[INFO] [stdout] 280 | |                     .context("creating git signature for new note")?;
[INFO] [stdout]     | |                                                                    -
[INFO] [stdout]     | |____________________________________________________________________|
[INFO] [stdout]     | |____________________________________________________________________this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                                                                      `#2` will be dropped later as of Edition 2024
[INFO] [stdout] 281 |                   let note_oid = repo
[INFO] [stdout]     |  ________________________________-
[INFO] [stdout]     | |________________________________|
[INFO] [stdout] 282 | |                     .note(
[INFO] [stdout] 283 | |                         &sig,
[INFO] [stdout] 284 | |                         &sig,
[INFO] [stdout] ...   |
[INFO] [stdout] 290 | |                     .with_context(|| format!("Adding notes to {}", handle.commit))?;
[INFO] [stdout]     | |                                                                                   -
[INFO] [stdout]     | |___________________________________________________________________________________|
[INFO] [stdout]     | |___________________________________________________________________________________this value will be stored in a temporary; let us call it `#3`
[INFO] [stdout]     |                                                                                     `#3` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 298 | |     }
[INFO] [stdout]     | |     - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#4` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.64/src/error.rs:581:1
[INFO] [stdout]     |
[INFO] [stdout] 581 | impl Drop for Error {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `result` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.64/src/error.rs:581:1
[INFO] [stdout]     |
[INFO] [stdout] 581 | impl Drop for Error {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/mpmc/mod.rs:1411:0
[INFO] [stdout] note: `handle` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/mpmc/mod.rs:1411:0
[INFO] [stdout] note: `sig` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/signature.rs:142:1
[INFO] [stdout]     |
[INFO] [stdout] 142 | impl<'a> Drop for Signature<'a> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.64/src/error.rs:581:1
[INFO] [stdout]     |
[INFO] [stdout] 581 | impl Drop for Error {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/git2-0.13.25/src/signature.rs:142:1
[INFO] [stdout]     |
[INFO] [stdout] 142 | impl<'a> Drop for Signature<'a> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] note: `#3` invokes this custom destructor
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.64/src/error.rs:581:1
[INFO] [stdout]     |
[INFO] [stdout] 581 | impl Drop for Error {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 50.17s
[INFO] [stderr] crater-edition-check: git-utils v0.1.0 (/opt/rustwide/workdir) updating edition from 2021 to 2024
[INFO] [stderr] error: failed to parse manifest at `/opt/rustwide/workdir/Cargo.toml`
[INFO] [stderr] 
[INFO] [stderr] Caused by:
[INFO] [stderr]   `default_features` is unsupported as of the 2024 edition; instead use `default-features`
[INFO] [stderr]   (in the `git2` dependency)
[INFO] running `Command { std: "docker" "inspect" "8deb27fe38a907cb42f8fb250e8aa37bc49c8cddec90ef49b6faf5b6eb3198f3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8deb27fe38a907cb42f8fb250e8aa37bc49c8cddec90ef49b6faf5b6eb3198f3", kill_on_drop: false }`
[INFO] [stdout] 8deb27fe38a907cb42f8fb250e8aa37bc49c8cddec90ef49b6faf5b6eb3198f3
